It's not the real issue. I introduced that while anonymizing the data. It's that a 3-5 liner code became a huge switch case by just incrementing the code and never thinking how it should be done. This was caused by like 15 engineers in time :)
Something like below would be huge improvement:
subs1 = ["cluster1", "cluster2"]
if subs1.contains(clusterName) return subs1
It is, but If you review 3 lines of pr and not the whole 50 lines of the file without thinking of the overall picture, this happens. I got this while reviewing a pr like this. And most probably I approved similar prs for this file in the past. Shame on me too..
15 Comments
n3cr0@lemmy.world · 10 pts · 3y
Tangent5280@lemmy.world · 6 pts · 3y
How do I view this image in full resolution on Jerboa? Currently only able to see the low res version
aktenkundig@discuss.tchncs.de · 3 pts · 3y
There's a download button in the top right. Not really convenient though, as you then need to go find the downloaded picture yourself.
Tangent5280@lemmy.world · 4 pts · 3y
Thank you, this helps, although jerboa really should have a button for full res right next to the download button.
nuez_jr@lemm.ee · 5 pts · 3y
If any post was ever deserving of a +1 this is it right here.
fsniper@kbin.social · 4 pts · 3y
And no reason to state this is from production.
beardedrhino@lemmy.ca · 5 pts · 3y
What am I looking at here? It just always goes to the first case right? 🤔
fsniper@kbin.social · 2 pts · 3y
It's not the real issue. I introduced that while anonymizing the data. It's that a 3-5 liner code became a huge switch case by just incrementing the code and never thinking how it should be done. This was caused by like 15 engineers in time :)
Something like below would be huge improvement:
Crackhappy@lemmy.world · 4 pts · 3y
Lol. Dude, you can't do that to a bunch of coders and not expect them to read it literally.
fsniper@kbin.social · 2 pts · 3y
Yep that's on me:) let's call this second breakfast!
Crackhappy@lemmy.world · 1 pts · 3y
Love you fam. :)
fsniper@kbin.social · 3 pts · 3y
no one looks behind and questions how and why.
Tangent5280@lemmy.world · 1 pts · 3y
No time in the development cycle for code review/refactors?
fsniper@kbin.social · 1 pts · 3y
It is, but If you review 3 lines of pr and not the whole 50 lines of the file without thinking of the overall picture, this happens. I got this while reviewing a pr like this. And most probably I approved similar prs for this file in the past. Shame on me too..