Notably for this community is the inclusion of the "lemmy-site" class on the #app div
I'm working on this draft PR to make theming and userscripts easier, feedback wanted! [Merged!]
https://github.com/LemmyNet/lemmy-ui/pull/1327
https://github.com/LemmyNet/lemmy-ui/pull/1327
Notably for this community is the inclusion of the "lemmy-site" class on the #app div
11 Comments
Zetaphor@zemmy.cc · 7 pts · 3y
@mershed_perderders@sh.itjust.works @CodingAndCoffee@lemmy.world, this PR was merged and will be released with 0.18
I'll see what I can do about those other requests 😉
mershed_perderders@sh.itjust.works · 2 pts · 3y
Excellent work! Thanks
mershed_perderders@sh.itjust.works · 3 pts · 3y
This is excellent and would have made coding the UI script so much easier!
Zetaphor@zemmy.cc · 3 pts · 3y
That's what kicked this whole thing off! I realized I was going to have to do all kinds of dumb stuff just to identify if I was actually looking at a lemmy site with any amount of certainty, and then it grew from there
mershed_perderders@sh.itjust.works · 1 pts · 3y
it was SO painful and hacky. Still will be until this gets out there.
Zetaphor@zemmy.cc · 1 pts · 3y
Please check the PR and let me know if there's anything I missed as far as good candidates for CSS targeting. I tried to use a light touch while being mindful of the different ways people may want to style both visible and parent structures
mershed_perderders@sh.itjust.works · 1 pts · 3y
looking at it now...
CodingAndCoffee@lemmy.world · 1 pts · 3y
Here's a few that would be helpful based on stuff I ran into in my userscript
Zetaphor@zemmy.cc · 3 pts · 3y
I just pushed a commit for the more-btn suggestion. The others look a bit more involved, but I think they are do-able. However I'm going to leave them for a separate PR as I would like this make sure this one gets into 0.18. That said I should be able to look into them next, just want to break this off and get it merged.
CodingAndCoffee@lemmy.world · 1 pts · 3y
Having all the various interaction buttons labeled, having a separate left-hand vs. right-hand footer location etc. would be helpful.
Being able to have a link from a comment to scroll up to the parent or up to the root like HackerNews would be fantastic but is currently kinda difficult without a lot of looping (slow on big threads)
mershed_perderders@sh.itjust.works · 1 pts · 3y
the thing that bugged me (and continues to do so) is the different uses of
.container-lgamong the pages.It is used differently between the community, search, main, and alert/messages area and it killed me trying to figure out the spacing relative to each use. In some cases I gave up...