My favorite code reviews are where the reviewer only comments about trivial shit that doesn't matter, like "it would be more readable if you added a newline here" type stuff.
I was in a team one where everyone could give or receive criticism, and it was always friendly and (often) constructive - hardly ever bad feelings. Learned a lot from them, really miss that team 😒
Whenever someone asks me to review something and I don't want to just move on, I just add a comment about adding more comments to the code or ask why a var was named that way.
5 Comments
bill_1992@lemmy.world · 7 pts · 3y
My favorite code reviews are where the reviewer only comments about trivial shit that doesn't matter, like "it would be more readable if you added a newline here" type stuff.
erock@lemmy.ml · 2 pts · 3y
https://bower.sh/human-linting
datendefekt@lemmy.ml · 7 pts · 3y
I was in a team one where everyone could give or receive criticism, and it was always friendly and (often) constructive - hardly ever bad feelings. Learned a lot from them, really miss that team 😒
readwallah@programming.dev · 3 pts · 3y
Whenever someone asks me to review something and I don't want to just move on, I just add a comment about adding more comments to the code or ask why a var was named that way.
screamin@lemmy.world · 2 pts · 3y
What's wrong with the person on the far right??? They look weirder the more i look at this