c/piefed_meta · by aeharding@vger.social · 1y

CORS doesn't work on the piefed API

Not sure where to post this: the Piefed API doesn't support CORS, at least testing against piefed.social, so requests from webapps like photon, alexandrite, voyager via PWA would not work.

Also, is there a way to pass a fedilink to resolve, like Lemmy resolveObject?

And lastly, how is Piefed planning on handling updates to the API for lemmy v1? Things like varying object type arrays being combined, and new/updated sorts.

Thanks!

36 points · 10 comments · view on lemmy.world

10 Comments

rimu@piefed.social · 12 pts · 1y (7 replies)

I've added CORS now :)

aeharding@vger.social · 5 pts · 1y

Nice, thanks! I’ll try it again soon

aeharding@vger.social · 3 pts · 1y (3 replies)

I checked piefed.social and I'm still getting CORS errors. Does the change still have yet to be deployed there?

rimu@piefed.social · 3 pts · 1y (2 replies)

It's working for me. Try this:

<!-- Save this as test-cors.html and open in a browser -->
<!DOCTYPE html>
<html>
  <body>
    <script>
      fetch("https://piefed.social/api/alpha/comment?id=6527216", {
        method: "GET", // or "POST", etc.
        headers: {
          "Content-Type": "application/json"
        }
      })
      .then(response => response.text())
      .then(data => console.log("Success:", data))
      .catch(error => console.error("CORS Error:", error));
    </script>
  </body>
</html>

aeharding@vger.social · 3 pts · 1y (1 reply)

Ah, that works, but this doesn't:

<!-- Save this as test-cors.html and open in a browser -->
<!DOCTYPE html>
<html>
  <body>
    <script>
      fetch("https://piefed.social/comment/6527914", {
        method: "GET", // or "POST", etc.
        headers: {
          "Content-Type": "application/json",
          Accept: "application/activity+json",
        },
      })
        .then((response) => response.text())
        .then((data) => console.log("Success:", data))
        .catch((error) => console.error("CORS Error:", error));
    </script>
  </body>
</html>

nor this:

<!-- Save this as test-cors.html and open in a browser -->
<!DOCTYPE html>
<html>
  <body>
    <script>
      fetch("https://piefed.social/.well-known/nodeinfo", {
        method: "GET", // or "POST", etc.
        headers: {
          "Content-Type": "application/json",
          Accept: "application/activity+json",
        },
      })
        .then((response) => response.text())
        .then((data) => console.log("Success:", data))
        .catch((error) => console.error("CORS Error:", error));
    </script>
  </body>
</html>

rimu@piefed.social · 3 pts · 1y

Ok technically those are not part of the API ;-)

I've put CORS headers on everything now, go for it.

keepthepace@slrpnk.net · 2 pts · 1y

Blaze@piefed.social · 1 pts · 1y

@aeharding@vger.social test

wjs018@piefed.social · 9 pts · 1y (2 replies)

Also, is there a way to pass a fedilink to resolve, like Lemmy resolveObject?

I don't think so yet...I think this issue is tracking it.

I can't really help with the others, but you might want to hop on the piefed matrix chat (#piefed-general:matrix.org). @rimu@piefed.social hangs out there and would have much better answers (during kiwi hours anyway).

Blaze@piefed.social · 2 pts · 1y (1 reply)

@aeharding@vger.social test

recursive_recursion@lemmy.ca · 1 pts · 1y

[ removed ]