If you go to your blocks on your settings page in the web UI (not in Voyager), are the blocked people listed in the table down near the bottom? I took a quick look through the /post/list endpoint in the PieFed api and it looks like we are filtering blocked users correctly, so I wonder if the issue is that user blocks are not getting created correctly.
I can confirm the blocked users are present in my piefed settings.
For testing, I blocked a user on Voyager - and verified that user appeared in Voyager's block list. Then I verified they appeared in Piefed block list - they did.
I restarted the Voyager app, forced a reload, then opened the post I blocked this test user from and I can still see their comment.
When I open this post on Piefed directly, I cannot see their comment as expected.
Ah, I see now. I had missed that this was for comments and not posts. I think I can see the bug in the PieFed API. The /comment/list endpoint is fairly complicated due to the way replies can be nested with different hierarchies, and I think it looks like it might not be filtering blocked users at a specific point. I opened an issue in the PieFed repo to keep track of this.
5 Comments
wjs018@piefed.social · 4 pts · 206d
If you go to your blocks on your settings page in the web UI (not in Voyager), are the blocked people listed in the table down near the bottom? I took a quick look through the
/post/listendpoint in the PieFed api and it looks like we are filtering blocked users correctly, so I wonder if the issue is that user blocks are not getting created correctly.rowdy@piefed.social · 3 pts · 206d
Thanks for the response!
I can confirm the blocked users are present in my piefed settings.
For testing, I blocked a user on Voyager - and verified that user appeared in Voyager's block list. Then I verified they appeared in Piefed block list - they did. I restarted the Voyager app, forced a reload, then opened the post I blocked this test user from and I can still see their comment.
When I open this post on Piefed directly, I cannot see their comment as expected.
wjs018@piefed.social · 7 pts · 206d
Ah, I see now. I had missed that this was for comments and not posts. I think I can see the bug in the PieFed API. The
/comment/listendpoint is fairly complicated due to the way replies can be nested with different hierarchies, and I think it looks like it might not be filtering blocked users at a specific point. I opened an issue in the PieFed repo to keep track of this.rowdy@piefed.social · 4 pts · 206d
Thanks for opening that, I really appreciate the help.
rimu@piefed.social · 1 pts · 55d
FYI this will be fixed in the next release of PieFed, due this week.