c/programming · by metw0@lemmy.world · 5d

simple sorting programm for Linux

wrote CLI in C++ to sort files. it's very simple, just download and use. if you a photographer, video editor or just need to sort some files, you welcome (link in post)

17 points · 11 comments · view on lemmy.world

11 Comments

thenextguy@sh.itjust.works · 11 pts · 5d (8 replies)

I don't think it is at all clear what this does.

It sorts files how?

bobo@lemmy.ml · 4 pts · 4d (6 replies)

It doesn't sort them in the programming sense, it's just moving files to another directory based on the filename

qsort -w /home/user/Documents -t ext --df .txt

is equivalent to

ls *.txt | xargs -I {} mv {} /home/user/Documents

MonkderVierte@lemmy.zip · 3 pts · 4d (5 replies)

Btw, you should not pipe ls. It's unsafe.

fruitcantfly@programming.dev · 8 pts · 4d (2 replies)

ls can be piped safely if you use --zero:

ls --zero *.txt | xargs --null -I {} mv {} /home/user/Documents

While the above is a pretty silly example, one reason why you might want to do this is that xargs has a -P/--max-procs argument, that runs N commands in parallel. So you could do something like the following to gzip four files in parallel:

ls --zero *.txt | xargs --null -n1 -P4 gzip

This is a bit simpler than using the equivalent

find . -maxdepth 1 -name '*.txt' -print0 | xargs --null -n1 -P4 gzip

MonkderVierte@lemmy.zip · 1 pts · 3d (1 reply)

While the later is more reliably available. Use this in scripts you distribute. And also finds -exec instead of |xargs.

fruitcantfly@programming.dev · 2 pts · 3d

Both find and xargs are POSIX commands, so there's something wrong with your OS if you are missing either, and find does not have an equivalent of -P. Granted, -P is an extension, but it is supported by GNU's, OpenBSD's, FreeBSD's, and BusyBox's xargs commands, and probably also by others, so it is reasonable to assume that it is available unless you are targeting some obscure OS

bobo@lemmy.ml · 4 pts · 4d (1 reply)

Source? I tried searching for it and found nothing.

BB_C@programming.dev · 7 pts · 4d

I think the other user meant that ls output is not supposed to be treated as parsable, because the tool doesn't offer any guarantees in that regards.

Shells have built-in support for globbing files anyway. xargs is also not needed. If someone is allergic to using a shell for loop, find always had -exec with ; instead + which wouldn't trip on too many arguments.

metw0@lemmy.world · 3 pts · 5d

this is just a practice project, I shared it just so other people could take a look. you can see how it sorts files by checking out the repository

fruitcantfly@programming.dev · 7 pts · 4d (1 reply)

Here are a few random thoughts based on skimming the source:

I'd advice againsts using -Weverything. Many of the warnings it enables are not very useful, and you are going to get a lot of them. And if you enable warnings, then fix them, or you'll just miss it when your changes cause new warnings.
A couple of your check functions may reach the end of the function without returning, if type is not on of the expected values. That is undefined behavior. One simple way to avoid this, is to move the common return out of the ifs.
That const std::string type argument in the above functions should be enums, since you are just checking againts one of three fixed values ("name", "ext", and "date").
Speaking of which, I can't think of any situation where you'd want to have an const std::string argument. Either use a const reference (const std::string&) or a string_view (const std::string_view). The latter has the advantage that it doesn't create a new std::string if you call the function with a C-string and it can be sliced cheaply.
You have const std::string &df = df_str; in a couple of places, where df_str is a std::string passed by value. That is of course utterly pointless, and you should simply change df_str to be passed by const reference or as a string view.
You define main with an int return type, but use std::exit to exit the function. Those std::exit calls could all be replaced with return, which does the same thing in main.
Don't do work before you need the results. For example, in check_type you perform two checks (saved as starts_with_dot and has_dash), that are not used if name == "name".
Nobody who sees a function named check_exists would expect it to create a directory, so it should be renamed to something more descriptive. It is also redundant, since you already check that the directory exists in main.cpp via is_directory, but unlike that check check_exists doesn't actually verify that the path is a directory.
is_founded is Engrish

metw0@lemmy.world · 2 pts · 22h

thanks for the detailed feedback, I appreciate it