Be...before I go. Could you approve all my experimental PRs?
Real story, I have a branch that's been open for four years at my company to add support for nested postgres transactions. It works flawlessly... but we, the senior devs, are uncertain if it's a power that would be used responsibly by the juniors. If I'm going to walk into the light, I'm going to make sure there's a badass explosion behind me.
I'm in the niche of niches by using vsc with a vim plugin while being a dvorak user. I rely on vim's langmap feature to get anywhere, but people implementing vim emulators blissfully ignore accessibility like that. So I went and implemented langmap in vsc's vim plugin myself. It has minimal intervention into the existing codebase and a bunch of other people have been wishing for this for years. Yet, when it comes to merging... Silence.
IMPORTANT: For those who are downvoting, yes, my entire comment is sarcasm, lol! Do not ever do anything like this in a shared repo, ever! If you actually do this in a shared repo, your access will likely be revoked the moment someone sane and competent realizes what you're doing.
Addendum: In that alias, I would've used left angle bracket instead of cat, but apparently lemmy scrubs those. I even tried the entity for it, but no go for either.
26 Comments
xmunk@sh.itjust.works · 84 pts · 2y
I disagree.
Real story, I have a branch that's been open for four years at my company to add support for nested postgres transactions. It works flawlessly... but we, the senior devs, are uncertain if it's a power that would be used responsibly by the juniors. If I'm going to walk into the light, I'm going to make sure there's a badass explosion behind me.
eluvatar@programming.dev · 11 pts · 2y
I've got one for a vscode feature (middle mouse click for go-to definition) that I want but the maintainers don't think it would be used.
Opisek@lemmy.world · 8 pts · 2y
I'm in the niche of niches by using vsc with a vim plugin while being a dvorak user. I rely on vim's langmap feature to get anywhere, but people implementing vim emulators blissfully ignore accessibility like that. So I went and implemented langmap in vsc's vim plugin myself. It has minimal intervention into the existing codebase and a bunch of other people have been wishing for this for years. Yet, when it comes to merging... Silence.
eluvatar@programming.dev · 4 pts · 2y
Can't you just open source your fork? I mean yeah it does suck but still. I've been in the same place and it does suck when they won't take your PR.
IHateReddit@lemmy.world · 1 pts · 2y
I try to use middle click for definition in vscode so often because you can do that in jetbrains IDEs...
eluvatar@programming.dev · 1 pts · 2y
Give this PR some love then. It works and it's magical but they don't seem interested in merging it in. https://github.com/microsoft/vscode/pull/154465
Artyom@lemm.ee · 6 pts · 2y
Godspeed my friend. 10/10 I would use that irresponsibly.
drolex@sopuli.xyz · 49 pts · 2y
You haven't written your unit tests and you have 675 compiling errors left. It's time to sleep grandpa
nx2@feddit.de · 13 pts · 2y
RIP
_dev_null@lemmy.zxcvn.xyz · 32 pts · 2y
That's why I've got my IDE configured to make a commit and push for every single ctrl-s.
And one more thing, I'm not going to squash before my final PR.
EDIT:
For those of you interested, here's my gitconfig alias to help with this workflow:
IMPORTANT: For those who are downvoting, yes, my entire comment is sarcasm, lol! Do not ever do anything like this in a shared repo, ever! If you actually do this in a shared repo, your access will likely be revoked the moment someone sane and competent realizes what you're doing.
Addendum: In that alias, I would've used left angle bracket instead of
cat, but apparently lemmy scrubs those. I even tried the entity for it, but no go for either.EatATaco@lemm.ee · 9 pts · 2y
Pure evil.
AstridWipenaugh@lemmy.world · 9 pts · 2y
Your sarcasm is brutal! That's sarcasm, right? RIGHT?!
jelloeater85@lemmy.world · 4 pts · 2y
Squash and Force Push. Your whole life in one line.
ntzm@lemmy.ml · 3 pts · 2y
Wouldn't that mean you just have shit tons of commits? What about the commit message?
EatATaco@lemm.ee · 7 pts · 2y
"Hit Ctrl-S"
TickleMeElmo@discuss.tchncs.de · 2 pts · 2y
I'd expect the poo emoji at that point.
_dev_null@lemmy.zxcvn.xyz · 2 pts · 2y
The more the merrier. I edited my comment above to show my git alias for comments :)
DmMacniel@feddit.de · 0 pts · 2y
Timestamp would suffice
ripcord@kbin.social · 3 pts · 2y
That sounds just awful. But ok.
ntzm@lemmy.ml · 1 pts · 2y
I meant whatever works for you, but if a coworker did that I would be fuming
ignotum@lemmy.world · 3 pts · 2y
Combine that with my pre-push hook that runs linting and tests, which takes about 10 minutes, and you're gonna have a good time
I've long ago disabled the tests and only run linting now, i'm not a machochist
HurlingDurling@lemm.ee · 8 pts · 2y
*commits
ERROR: There are 5000 conflicts, please resolve them before pushing
Giraffe00@lemmy.world · 2 pts · 2y
It's too late.
White_Flight@lemmy.world · 1 pts · 2y
I must be dumb, I don't get it
Traister101@lemmy.today · 3 pts · 2y
Git. The joke is they have stuff locally they want to push to a remote
sag@lemm.ee · 1 pts · 2y
And make the production down.