[Shattered Pixel Dungeon v3.2.5] BUG Report - Infinite loop causing game to freeze

@00_Evan@lemmy.world

Some rare seeds will cause an NPC, in this case Wandmaker, to get stuck in an infinite loop trying to spawn.

I could have perhaps made a fix and do a PR on Github, but as there are several ways to address it, as well as the possibility similar issues might happen with Ghost or Imp, I'm posting here.

---

Issue:

Game freeze. Wandmaker is stuck in an infinite loop attempting to spawn.

---

File:

.../core/src/main/java/com/shatteredpixel/shatteredpixeldungeon/actors/mobs/npcs/Wandmaker.java

---

Method:

spawnWandmaker(...)

---

Lines:

305-321

---

Reproducibility:

Game seed RAT-KCA-BLR will attempt to spawn Wandmaker on floor 8 in a 7x7 room (see screenshot), within the middle 3x3 area. All tiles here are considered not valid due to traps, entrance, or non-solid ground, including the bridge.

---

Suggestions:

• Limit number of spawn attempts (ie. 100). If failed, consider trapped locations to be valid, optionally erasing any trap under the Wandmaker.
• Alternative is to spawn a new room with same width/height after x attempts, overwriting the old room and try again.

---