First PR approved on Piefed!

Got my first PR approved on piefed! And now I am seeing it on my tiny little machine. Feels good.

Hopefully it helps other admins out in the long run.

104 points · 10 comments · view on lemmy.world

10 Comments

wjs018@piefed.social · 16 pts · 226d (1 reply)

JSON never looked better!

Relevant PR

michael@piefed.chrisco.me · 16 pts · 226d

Im seriously surprised how fast all that went! Like it was an idea, PR, merge, out on my yunohost in a week or two. Thats insane iteration!

Thanks again for the PR/help!

Remember_the_tooth@lemmy.world · 12 pts · 226d (4 replies)

What's "PR" in this context? I don't know much about piefed, but I'm very pro-fediverse and happy to learn.

michael@piefed.chrisco.me · 26 pts · 226d (1 reply)

Sorry common programmer lingo. It means Pull Request.

Someone reviewed a thing I did, gave it the ok and we threw it into a program (piefed). Now we see said thing the wild.

Remember_the_tooth@lemmy.world · 10 pts · 226d

Thanks for ELI5! That was really helpful. Congratulations!

wjs018@piefed.social · 7 pts · 226d

PR in this context is a pull request. It is a way for people to contribute code to an open source project. Random explainer I found.

chasingtheflow@lemmy.world · 5 pts · 226d

Pull request, a term used in version control systems for software development.

Meaning a developer requests to the project maintainers that they include their changes and if accepted the maintainers “pull” their code in and merge it with the maintainers project code.

Jeffdude@piefed.social · 6 pts · 226d (1 reply)

Congrats but I believe yoda would say “Approved the PR is.” No extra “it” necessary here.

threelonmusketeers@sh.itjust.works · 1 pts · 214d

And there should technically be a comma:

"Approved, the PR is."

Blaze@piefed.zip · 3 pts · 226d

Thank you!