For me personally this feels very wrong. What do you think about that?
Remove "final" keywords from classes and methods in vendor packages with Unfinalize
https://laravel-news.com/unfinalize
https://laravel-news.com/unfinalize
For me personally this feels very wrong. What do you think about that?
5 Comments
pivot_root@lemmy.world · 4 pts · 2y
Final keywords–like locks on a door–are just a suggestion. If someone wants to light a stick of dynamite and play hot potato with it, that's their own problem. As long as they aren't wasting upstream dev's time or publishing packages that depend on this to work, it's not worth getting upset about.
alx@programming.dev · 5 pts · 2y
But exactly this will happen.
TheCee@programming.dev · 2 pts · 2y
Another red flag for people hired to maintain that code, I guess.
dbx12@programming.dev · 2 pts · 2y
alx@programming.dev · 1 pts · 2y
In my opinion, the package itself is bad. It suggests by its very existence that
finalis bad. It tempts to use dependencies in a way that was not intended by their developers.TheCee@programming.dev · 2 pts · 2y
This. And, unlike Lombok, there is no -deUnfinalize. Sure seems like youre stuck with fixing your codebase, when this thing finally folds.
dbx12@programming.dev · 1 pts · 2y