c/mildlyinfuriating · by jeena@jemmy.jeena.net · 3y

I found a nice and easy lemmy bug to fix, but someone beat me to it by 18 hours.

https://github.com/LemmyNet/lemmy-ui/commit/92f6fe914fce3838fa9ad12333f72e5db5535518

I already forked the ui-repo, found the correct file to fix it and even found the place where I should add a query to the search form to search only for communities if you start searching from the communities page.

But then I saw that this change is already done in that file. I double checked the HTML on my instance and there it's broken. I checked the history of the page and see it has been fixed 18 hours before I started looking into it.

All my hard work for nothing.

190 points · 20 comments · view on lemmy.world

20 Comments

withersailor@aussie.zone · 61 pts · 3y (4 replies)

It wasn't for nothing.

Think of the skills you gained and the experience.

dwindling7373@feddit.it · 40 pts · 3y (3 replies)

And a chance to post it here!

Scribbd@feddit.nl · 34 pts · 3y (2 replies)

And all the larma to gain!

Quills@sh.itjust.works · 16 pts · 3y (1 reply)

Larma^ That's how I'm calling it now

Pneuma@lemmy.ca · 1 pts · 3y

Winamp. It really whips the Larma's ass! Baaah

lml@remy.city · 36 pts · 3y

At least you got yourself into the contributing mindset. Tackle the next issue!

ellesper@lemmy.world · 29 pts · 3y

It be like that sometimes

boopdepop@lemmy.fmhy.ml · 23 pts · 3y

Hey, if not this one then the next one. Onto the next bug!

alejandro@lemmy.world · 18 pts · 3y

That’s why you should always search for or file a bug report before trying to create a fix.

marty@discuss.tchncs.de · 14 pts · 3y (1 reply)

Lesson learned, always pull and branch from main.

jeena@jemmy.jeena.net · 4 pts · 3y

Actually I was working on the main and that's where I saw it being fixed :D

jeena@jemmy.jeena.net · 12 pts · 3y

I have another bug which is bothering me. When the site settings are set to "Registration Mode": "Close Registration", the Sign Up link still shows up and the route still sends you to the Sign Up form. You can fill in everything there but then will get a infinite spinner.

I wanted to at least remove the link at the top when sign up is closed. But obviously it's not as easy as changing a static HTML as in the other bug.

scottyjoe9@sh.itjust.works · 12 pts · 3y

Plenty more bugs to fix, don't give up being a contributor!

My process is:

Check for an issue that describes the bug you're seeing.
If there isn't one, create one.
If you feel like it'll be snapped up because it's a relatively easy fix, comment on the issue saying you'll give it a go.
Fix it!

There is still a chance someone might swoop in and fix it but this lowers the chances and it's good to get into the habit of creating and linking Issues to your PRs.

lunarul@kbin.social · 11 pts · 3y

That type of bug is what is called "low hanging fruit". With lots of active contributors, such bugs will get fixed pretty quickly.

canpolat@programming.dev · 10 pts · 3y

You can just build a time machine and commit it before the other one. Problem solved.

xavier666@lemm.ee · 7 pts · 3y (1 reply)

If it's a nice and easy bug, better just make a bug report out of it.

jeena@jemmy.jeena.net · 7 pts · 3y

It's already fixed, no need for more paper.

Two9A@lemmy.world · 4 pts · 3y

I had this exact thing with Mastodon a few days ago. Couldn't find a way to get the local server's post-ID for a federated post if you had the original URL, so I thought "screw it, I'll do it myself".

Downloaded the source, set up a local instance, added extra space to my server so I could run ElasticSearch, went to the file where I wanted to add my "uri:" search prefix, and I find (to paraphrase)...

Send resolve=true to fetch remote instances and return their local ID

Been there for years.

gogosempai@programming.dev · 2 pts · 3y (1 reply)

Good to see active development on the repo! I'm a Golang dev but I've been interested in Rust for quite some time now. Maybe I'll start with Lemmy :)

subash@programming.dev · 2 pts · 3y

yes