MrKaplan

u/MrKaplan@piefed.world
0 posts · 40 comments

Recent posts

No posts.

Recent comments

it seems like voyager might be the only one displaying it correctly?

assuming that voyager is indeed displaying it correctly, that would indicate that mlem isn't handling the error correctly, as it seems to unconditionally try to access the url of the upload and failing to do so.

the web interface is probably also just not exposing the error message correctly.

you should be able to see your upload volume here: https://piefed.world/user/files

the default limit in piefed is 50MB, which is rather easily reached. can you please confirm if you're indeed hitting that limit?

quota exceeded is a very useful error message, that means it's likely an issue specific to the amount of media uploaded by your user. i'll have to check how upload quota is determined, but this is is not something we have customized. i suspect that this was intentionally changed with one of the version updates, probably not accounting well enough for people commenting as much as you do. it should not be related to the recent vulnerabilities.

mostly indexes and in some cases changing queries.

there are lots of queries in piefed that are not using indexes and some that are just unoptimized sql statements. for example, there are a lot of like '%foo%' queries but there are no GIN indexes to support those queries.

unfortunately it's a hassle to manage custom indexes as they can't be part of the code migrations without fucking other things up, so for the time being i'm just keeping track of them by having a dedicated prefix for the index names and updating them in our DB manually. once/if they're upstreamed i'm removing our custom ones again, but it's not possible for us to track them in code.

some of the code changes for sql statements were upstreamed, but rimu didn't want to incorporate all of them without evidence of performance impact. it took me a bit to make sense of the more complex statements, but i don't have time or motivation to demonstrate performance impact for them, so i'll just keep the remainder in our fork. e.g. 1bf4d8409b vs c41d47850e.